Merge pull request #13 from Horttcore/analysis-KZJapQ

Apply fixes from StyleCI
Horttcore · Sep 8, 2020 · fc967c9 · fc967c9
2 parents ac4891e + 1666b7e
commit fc967c9
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 17 deletions.
diff --git a/classes/custom-post-type-staff.admin.php b/classes/custom-post-type-staff.admin.php
@@ -91,13 +91,14 @@ public function manage_staff_posts_custom_column($column, $post_id)
 
         $meta = get_post_meta($post_id, '_staff-meta', true);
 
-        switch ($column) :
+        switch ($column) {
 
             case 'thumbnail':
-                if (!has_post_thumbnail($post_id)) :
-                    echo '<img src="http://www.gravatar.com/avatar/'.md5($meta['email']).'?d=mm" />'; else :
+                if (!has_post_thumbnail($post_id)) {
+                    echo '<img src="http://www.gravatar.com/avatar/'.md5($meta['email']).'?d=mm" />';
+                } else {
                     echo get_the_post_thumbnail($post_id, 'thumbnail');
-        endif;
+                }
         break;
 
         case 'phone':
@@ -119,7 +120,7 @@ public function manage_staff_posts_custom_column($column, $post_id)
         default:
                 break;
 
-        endswitch;
+        }
     }
 
     // END manage_staff_posts_custom_column

diff --git a/classes/custom-post-type-staff.block.php b/classes/custom-post-type-staff.block.php
@@ -53,11 +53,9 @@ public function render($attributes)
             ]);
         }
 
-        if ($query->have_posts()) :
-
+        if ($query->have_posts()) {
             require apply_filters('custom-post-type-staff-loop-template', plugin_dir_path(__FILE__).'../views/loop.php', $query, $attributes);
-
-        endif;
+        }
 
         return ob_get_clean();
     }

diff --git a/views/loop.php b/views/loop.php
@@ -1,10 +1,10 @@
 <section class="staff">
     <div class="posts posts--staff">
         <?php
-        while ($query->have_posts()) :
+        while ($query->have_posts()) {
             $query->the_post();
             require apply_filters('custom-post-type-staff-single-template', plugin_dir_path(__FILE__).'single.php', $query, $attributes);
-        endwhile;
+        }
         ?>
     </div>
 </section>
diff --git a/views/single.php b/views/single.php
@@ -1,10 +1,10 @@
 <aside <?php post_class() ?>>
 
-    <?php if (has_post_thumbnail()) : ?>
+    <?php if (has_post_thumbnail()) { ?>
         <figure class="staff__image">
             <?php the_post_thumbnail(apply_filters('custom-post-type-staff-image-size', 'thumbnail'), ['class' => 'staff__image__img']); ?>
         </figure>
-    <?php endif ?>
+    <?php } ?>
 
     <div class="staff__wrapper">
 
@@ -14,16 +14,16 @@
         </header>
 
         <div class="staff__content">
-            <?php if (has_staff_meta('phone')) : ?>
+            <?php if (has_staff_meta('phone')) { ?>
                 <a href="<?php the_staff_meta('phone', 'tel:')?>">
                     <?php the_staff_meta('phone', '<div class="staff__phone">', '</div>') ?>
                 </a>
-            <?php endif ?>
-            <?php if (has_staff_meta('role')) : ?>
+            <?php } ?>
+            <?php if (has_staff_meta('role')) { ?>
                 <a href="<?php the_staff_meta('email', 'mailto:')?>">
                     <?php the_staff_meta('email', '<div class="staff__email">', '</div>') ?>
                 </a>
-            <?php endif ?>
+            <?php } ?>
         </div>
 
     </div>