Merge pull request react-bootstrap#1281 from AlexKVal/airbnb

Next portion of `airbnb`

.eslintrc

@@ -25,16 +25,10 @@
     "no-param-reassign": 0,
     "no-this-before-super": 2,
     "no-undef": 2,
-    "no-unused-vars": [2, { "vars": "all", "args": "none" }],
     "babel/object-shorthand": 2,
     "react/jsx-boolean-value": [2, "never"],
     "react/jsx-no-duplicate-props": 2,
     "react/prop-types": [2, { "ignore": [ "children", "className", "style" ] }],
-    "react/sort-comp": 0,
-    "space-after-keywords": 0,
-    "space-before-blocks": 0,
-    "space-before-function-paren": 0,
-    "spaced-comment": 0,
-    "vars-on-top": 0
+    "react/sort-comp": 0
   }
 }

docs/build.js

@@ -25,7 +25,7 @@ const readmeDest = path.join(docsBuilt, 'README.md');
  * @internal
  */
 function generateHTML(fileName, propData) {
-  return new Promise((resolve, reject) => {
+  return new Promise( resolve => {
     const urlSlug = fileName === 'index.html' ? '/' : `/${fileName}`;
 
     Router.run(routes, urlSlug, Handler => {

docs/examples/Collapse.js

@@ -1,11 +1,11 @@
 class Example extends React.Component {
-  constructor(...args){
+  constructor(...args) {
     super(...args);
 
     this.state = {};
   }
 
-  render(){
+  render() {
     return (
       <div>
         <Button onClick={ ()=> this.setState({ open: !this.state.open })}>

docs/examples/DropdownButtonBasic.js

@@ -1,6 +1,6 @@
 const BUTTONS = ['Default', 'Primary', 'Success', 'Info', 'Warning', 'Danger', 'Link'];
 
-function renderDropdownButton (title, i) {
+function renderDropdownButton(title, i) {
   return (
     <DropdownButton bsStyle={title.toLowerCase()} title={title} key={i} id={`dropdown-basic-${i}`}>
       <MenuItem eventKey="1">Action</MenuItem>

docs/examples/DropdownButtonCustomMenu.js

@@ -1,13 +1,13 @@
 
 class CustomMenu extends React.Component {
 
-  constructor(...args){
+  constructor(...args) {
     super(...args);
     this.state = { value: '' };
     this.onChange = e => this.setState({ value: e.target.value });
   }
 
-  render(){
+  render() {
     let { className, ...props } = this.props;
 
     return (
@@ -30,7 +30,7 @@ class CustomMenu extends React.Component {
     );
   }
 
-  filterChildren(){
+  filterChildren() {
     let { children } = this.props;
     let { value } = this.state;
     let filtered = [];

docs/examples/Fade.js

@@ -1,12 +1,12 @@
 
 class Example extends React.Component {
 
-  constructor(...args){
+  constructor(...args) {
     super(...args);
     this.state = {};
   }
 
-  render(){
+  render() {
     return (
       <div>
         <Button onClick={()=> this.setState({ open: !this.state.open })}>

docs/examples/ListGroupLinked.js

@@ -1,4 +1,4 @@
-function alertClicked () {
+function alertClicked() {
   alert('You clicked the third ListGroupItem');
 }
 

docs/examples/MenuItem.js

@@ -1,4 +1,4 @@
-function onSelectAlert(eventKey, href, target) {
+function onSelectAlert(eventKey, href) {
   alert('Alert from menu item.\neventKey: "' + eventKey + '"\nhref: "' + href + '"');
 }
 

docs/examples/Modal.js

@@ -1,14 +1,14 @@
 const Example = React.createClass({
 
-  getInitialState(){
+  getInitialState() {
     return { showModal: false };
   },
 
-  close(){
+  close() {
     this.setState({ showModal: false });
   },
 
-  open(){
+  open() {
     this.setState({ showModal: true });
   },
 

docs/examples/ModalContained.js

@@ -10,19 +10,19 @@
  */
 
 const Trigger = React.createClass({
-  getInitialState(){
+  getInitialState() {
     return { show: false };
   },
 
   render() {
-    let close = e => this.setState({ show: false});
+    let close = () => this.setState({ show: false});
 
     return (
       <div className="modal-container" style={{height: 200}}>
         <Button
           bsStyle="primary"
           bsSize="large"
-          onClick={e => this.setState({ show: true})}
+          onClick={() => this.setState({ show: true})}
         >
           Launch contained modal
         </Button>

docs/examples/ModalDefaultSizing.js

@@ -53,12 +53,12 @@ const MyLargeModal = React.createClass({
 });
 
 const App = React.createClass({
-  getInitialState(){
+  getInitialState() {
     return { smShow: false, lgShow: false };
   },
-  render(){
-    let smClose = e => this.setState({ smShow: false });
-    let lgClose = e => this.setState({ lgShow: false });
+  render() {
+    let smClose = () => this.setState({ smShow: false });
+    let lgClose = () => this.setState({ lgShow: false });
 
     return (
       <ButtonToolbar>

docs/examples/NavBasic.js

@@ -1,4 +1,4 @@
-function handleSelect (selectedKey) {
+function handleSelect(selectedKey) {
   alert('selected ' + selectedKey);
 }
 

docs/examples/NavStacked.js

@@ -1,4 +1,4 @@
-function handleSelect (selectedKey) {
+function handleSelect(selectedKey) {
   alert('selected ' + selectedKey);
 }
 

docs/examples/Overlay.js

@@ -1,20 +1,20 @@
 
 const Example = React.createClass({
-  getInitialState(){
+  getInitialState() {
     return { show: true };
   },
 
-  toggle(){
+  toggle() {
     this.setState({ show: !this.state.show });
   },
 
-  render(){
+  render() {
     const tooltip = <Tooltip>Tooltip overload!</Tooltip>;
 
     const sharedProps = {
       show: this.state.show,
       container: this,
-      target: props => React.findDOMNode(this.refs.target)
+      target: () => React.findDOMNode(this.refs.target)
     };
 
     return (

docs/examples/OverlayCustom.js

@@ -1,14 +1,14 @@
 
 const Example = React.createClass({
-  getInitialState(){
+  getInitialState() {
     return { show: true };
   },
 
-  toggle(){
+  toggle() {
     this.setState({ show: !this.state.show });
   },
 
-  render(){
+  render() {
     const style = {
       position: 'absolute',
       backgroundColor: '#EEE',
@@ -31,7 +31,7 @@ const Example = React.createClass({
           onHide={() => this.setState({ show: false })}
           placement="right"
           container={this}
-          target={ props => React.findDOMNode(this.refs.target)}
+          target={() => React.findDOMNode(this.refs.target)}
         >
           <div style={style}>
             <strong>Holy guacamole!</strong> Check this info.

docs/examples/PaginationBasic.js

@@ -5,7 +5,7 @@ const PaginationBasic = React.createClass({
     };
   },
 
-  handleSelect(event, selectedEvent){
+  handleSelect(event, selectedEvent) {
     this.setState({
       activePage: selectedEvent.eventKey
     });

docs/examples/PanelCollapsible.js

@@ -1,12 +1,12 @@
 class Example extends React.Component {
-  constructor(...args){
+  constructor(...args) {
     super(...args);
     this.state = {
       open: true
     };
   }
 
-  render(){
+  render() {
     return (
       <div>
         <Button onClick={ ()=> this.setState({ open: !this.state.open })}>

docs/examples/PopoverContained.js

@@ -1,9 +1,9 @@
 class Example extends React.Component {
-  constructor(...args){
+  constructor(...args) {
     super(...args);
     this.state = { show: false };
   }
-  render(){
+  render() {
     return (
       <ButtonToolbar>
         <Button

docs/examples/SplitButtonBasic.js

@@ -1,6 +1,6 @@
 const BUTTONS = ['Default', 'Primary', 'Success', 'Info', 'Warning', 'Danger'];
 
-function renderDropdownButton (title, i) {
+function renderDropdownButton(title, i) {
   return (
     <SplitButton bsStyle={title.toLowerCase()} title={title} key={i} id={`split-button-basic-${i}`}>
       <MenuItem eventKey="1">Action</MenuItem>

docs/generate-metadata.js

@@ -26,7 +26,7 @@ let isLiteral = str => (/^('|")/).test(str.trim());
  *
  * @param  {ComponentMetadata|PropMetadata} obj
  */
-function parseDoclets(obj){
+function parseDoclets(obj) {
   obj.doclets = metadata.parseDoclets(obj.desc || '') || {};
   obj.desc = cleanDoclets(obj.desc || '');
   obj.descHtml = marked(obj.desc || '');
@@ -39,7 +39,7 @@ function parseDoclets(obj){
  * @param  {Object} props     Object Hash of the prop metadata
  * @param  {String} propName
  */
-function applyPropDoclets(props, propName){
+function applyPropDoclets(props, propName) {
   let prop = props[propName];
   let doclets = prop.doclets;
   let value;
@@ -72,8 +72,8 @@ function applyPropDoclets(props, propName){
 }
 
 
-export default function generate(destination, options = { mixins: true, inferComponent: true }){
-  return globp(__dirname + '/../src/**/*.js') //eslint-disable-line no-path-concat
+export default function generate(destination, options = { mixins: true, inferComponent: true }) {
+  return globp(__dirname + '/../src/**/*.js') // eslint-disable-line no-path-concat
     .then( files => {
       let results = files.map(
         filename => fsp.readFile(filename).then(content => metadata(content, options)) );
@@ -96,7 +96,7 @@ export default function generate(destination, options = { mixins: true, inferCom
               });
             });
 
-            //combine all the component metadata into one large object
+            // combine all the component metadata into one large object
             result = { ...result, ...components };
           });
 

docs/server.js

@@ -21,7 +21,7 @@ if (development) {
   let webpackPort = process.env.WEBPACK_DEV_PORT;
   let target = `http://${ip.address()}:${webpackPort}`;
 
-  app.get('/assets/*', function (req, res) {
+  app.get('/assets/*', function(req, res) {
     proxy.web(req, res, { target });
   });
 
@@ -49,7 +49,7 @@ if (development) {
   app.use(express.static(path.join(__dirname, '../docs-built')));
 }
 
-app.listen(port, function () {
+app.listen(port, function() {
   console.log(`Server started at:`);
   console.log(`- http://localhost:${port}`);
   console.log(`- http://${ip.address()}:${port}`);

docs/src/HomePage.js

@@ -7,7 +7,7 @@ import Alert from '../../src/Alert';
 import Glyphicon from '../../src/Glyphicon';
 import Label from '../../src/Label';
 
-export default class HomePage extends React.Component{
+export default class HomePage extends React.Component {
   render() {
     return (
       <div>

docs/src/PropTable.js

@@ -8,7 +8,7 @@ import Table from '../../src/Table';
 let cleanDocletValue = str => str.trim().replace(/^\{/, '').replace(/\}$/, '');
 let capitalize = str => str[0].toUpperCase() + str.substr(1);
 
-function getPropsData(component, metadata){
+function getPropsData(component, metadata) {
   let componentData = metadata[component] || {};
   let props = componentData.props || {};
 
@@ -38,14 +38,14 @@ const PropTable = React.createClass({
     metadata: React.PropTypes.object
   },
 
-  componentWillMount(){
+  componentWillMount() {
     this.propsData = getPropsData(this.props.component, this.context.metadata);
   },
 
-  render(){
+  render() {
     let propsData = this.propsData;
 
-    if ( !Object.keys(propsData).length){
+    if ( !Object.keys(propsData).length) {
       return <span/>;
     }
 
@@ -66,7 +66,7 @@ const PropTable = React.createClass({
     );
   },
 
-  _renderRows(propsData){
+  _renderRows(propsData) {
     return Object.keys(propsData)
       .sort()
       .filter(propName => propsData[propName].type && !propsData[propName].doclets.private )
@@ -107,7 +107,7 @@ const PropTable = React.createClass({
     );
   },
 
-  renderControllableNote(prop, propName){
+  renderControllableNote(prop, propName) {
     let controllable = prop.doclets.controllable;
     let isHandler = this.getDisplayTypeName(prop.type.name) === 'function';
 

docs/src/Root.js

@@ -30,7 +30,7 @@ const Root = React.createClass({
     metadata: React.PropTypes.object
   },
 
-  getChildContext(){
+  getChildContext() {
     return { metadata: this.props.propData };
   },