Merge pull request react-bootstrap#505 from AlexKVal/lnt_src2

[fixed] Missed propTypes validations for SplitButton, Input, TabPane, CarouselItem
Hosar · Apr 10, 2015 · 5ce17e9 · 5ce17e9
2 parents ba7e7c4 + f3ae67e
commit 5ce17e9
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 4 deletions.
diff --git a/src/CarouselItem.js b/src/CarouselItem.js
@@ -7,7 +7,10 @@ const CarouselItem = React.createClass({
     direction: React.PropTypes.oneOf(['prev', 'next']),
     onAnimateOutEnd: React.PropTypes.func,
     active: React.PropTypes.bool,
-    caption: React.PropTypes.node
+    animateIn: React.PropTypes.bool,
+    animateOut: React.PropTypes.bool,
+    caption: React.PropTypes.node,
+    index: React.PropTypes.number
   },
 
   getInitialState() {

diff --git a/src/Input.js b/src/Input.js
@@ -28,7 +28,9 @@ const Input = React.createClass({
     groupClassName: React.PropTypes.string,
     wrapperClassName: React.PropTypes.string,
     labelClassName: React.PropTypes.string,
-    disabled: React.PropTypes.bool
+    multiple: React.PropTypes.bool,
+    disabled: React.PropTypes.bool,
+    value: React.PropTypes.any
   },
 
   getInputDOMNode() {

diff --git a/src/SplitButton.js b/src/SplitButton.js
@@ -1,3 +1,5 @@
+/* eslint react/prop-types: [1, {ignore: ["children", "className", "bsSize"]}]*/
+/* BootstrapMixin contains `bsSize` type validation */
 import React from 'react';
 import classNames from 'classnames';
 import BootstrapMixin from './BootstrapMixin';
@@ -16,6 +18,7 @@ const SplitButton = React.createClass({
     id:            React.PropTypes.string,
     target:        React.PropTypes.string,
     dropdownTitle: React.PropTypes.node,
+    dropup:        React.PropTypes.bool,
     onClick:       React.PropTypes.func,
     onSelect:      React.PropTypes.func,
     disabled:      React.PropTypes.bool

diff --git a/src/TabPane.js b/src/TabPane.js
@@ -4,7 +4,9 @@ import TransitionEvents from './utils/TransitionEvents';
 
 const TabPane = React.createClass({
   propTypes: {
-    active: React.PropTypes.bool
+    active:          React.PropTypes.bool,
+    animation:       React.PropTypes.bool,
+    onAnimateOutEnd: React.PropTypes.func
   },
 
   getDefaultProps() {
@@ -60,7 +62,7 @@ const TabPane = React.createClass({
         animateOut: false
       });
 
-      if (typeof this.props.onAnimateOutEnd === 'function') {
+      if (this.props.onAnimateOutEnd) {
         this.props.onAnimateOutEnd();
       }
     }