-
-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #292 - Affiliate & Category (drilldown) views don't work #359
Conversation
Please merge your viewset changes into the developer examples and other viewsets. |
@@ -166,9 +166,12 @@ public string ToJson() | |||
[RegularExpression(@"[-\w]*", ErrorMessage = "Only alpha-numeric and '-', '_' characters are allowed")] | |||
public string ReferralAffiliateId { get; set; } | |||
|
|||
public bool IsTrue => true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change this to a standard property. The build process won't recognize this version of C# (right now).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@erw13n I don't see your update on this one yet?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Understood, I'll update it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I already update it, its on commit of "Update the other Viewset" below.
OK, I'll update the other viewset. |
Please see the other code review note as well. This PR is blocked right now. :( |
@@ -166,7 +166,7 @@ public string ToJson() | |||
[RegularExpression(@"[-\w]*", ErrorMessage = "Only alpha-numeric and '-', '_' characters are allowed")] | |||
public string ReferralAffiliateId { get; set; } | |||
|
|||
public bool IsTrue => true; | |||
public bool IsTrue { get { return true; } } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@WillStrohl It's been update in here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@WillStrohl This commit contain change for other viewset: MyBootstrap3, MyLegacy, MyViewset, Porto5 & SocialSpokes
Fix #292 include :
Tested on :