Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move require rotp library to the file where it is used #55

Merged
merged 1 commit into from
Dec 15, 2015

Conversation

gkopylov
Copy link
Contributor

It is ok when I check it in development environment, but when I run some tests there are many errors uninitialized constant Devise::Models::TwoFactorAuthenticatable::InstanceMethodsOnActivation::ROTP. I think it is because require 'rotp' is not in appropriate place.

@gkopylov
Copy link
Contributor Author

Btw there are some another problems(perhaps because I am using it with mongoid). For example, I need to require 'two_factor_authentication/models/two_factor_authenticatable.rb' directly in my User class, so without it I getting error uninitialized constant Devise::Models::TwoFactorAuthenticatable. And yet another problem is that after all that done(that I mentioned above) there are still some errors like undefined method is_fully_authenticated?' for #UsersController:0x000000037358b8. It seems that method is_fully_authenticated?` is not added as a helper to ApplicationController. Any thoughts about it? Or it better to create another issue for that? Again, all is ok, when I just use it, but errors appear when I run my tests with rspec.

Houdini added a commit that referenced this pull request Dec 15, 2015
Move require rotp library to the file where it is used
@Houdini Houdini merged commit 6c4927d into Houdini:master Dec 15, 2015
monfresh pushed a commit to monfresh/two_factor_authentication that referenced this pull request Dec 22, 2015
Move require rotp library to the file where it is used
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants