Drop support for Ruby 1.9.3 & update .travis.yml #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monfresh
force-pushed
the
update-travis-config
branch
from
d6f8c1e
to
32680f7
Compare
monfresh
changed the title
monfresh
force-pushed
the
update-travis-config
branch
from
32680f7
to
70f5b34
Compare
|
@Houdini What do you think about this? It fixes the latest Travis issues, but we need to drop support for Ruby 1.9.3 because the OTP encryption requires 2.0 or later. |
**Why**: The `encryptor` gem, which is used for the new OTP encryption feature, requires Ruby 2.0 or later. Also, Rails 5.0 requires Ruby 2.2.2 or greater, so we need to ignore 1.9.3, 2.0, and 2.1 when running RAILS_VERSION=master on Travis.
monfresh
force-pushed
the
update-travis-config
branch
from
70f5b34
to
e762e99
Compare
Houdini
added a commit
that referenced
this pull request
Jan 14, 2016
Drop support for Ruby 1.9.3 & update .travis.yml
|
It's fine. I don't think many people really use 1.9.3 |
|
Sounds good. When do you think you can push a new release to RubyGems? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
The
encryptorgem, which is used for the new OTP encryption feature,requires Ruby 2.0 or later.
Also, Rails 5.0 requires Ruby 2.2.2 or greater, so we need to ignore
1.9.3, 2.0, and 2.1 when running RAILS_VERSION=master on Travis.