New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve text-fragment-to-quotation and quotation-to-text-fragment process #500

Closed

4 tasks done

Tracked by

carlgieringer opened this issue Aug 6, 2023 · 0 comments · Fixed by #501

Closed

4 tasks done

Tracked by

Improve text-fragment-to-quotation and quotation-to-text-fragment process #500

carlgieringer opened this issue Aug 6, 2023 · 0 comments · Fixed by #501

Assignees

Contributor

carlgieringer commented Aug 6, 2023 •

edited

Loading

Issues:

Fragment link -> quotation: good but loses linebreaks
Quotation -> fragment link: text fragment often doesn't work

TODO:

custom check that howdju-text-fragment-generation dist is current
copy howdju-text-fragment-generation to lamda during release
Improve quotation inference. Visit nodes between start/end. Add two new lines whenever leaving a paragraph and add text content of all non-empty text nodes. Trim the final result.
Generate better text fragment link

carlgieringer mentioned this issue

Improve source handling #38

Open

45 tasks

carlgieringer self-assigned this

carlgieringer mentioned this issue

Improve quotation inference and text fragment link generation #501

Merged

carlgieringer closed this as completed in #501

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment