Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve source handling #38

Open
37 of 45 tasks
carlgieringer opened this issue Jul 14, 2021 · 0 comments · Fixed by #415
Open
37 of 45 tasks

Improve source handling #38

carlgieringer opened this issue Jul 14, 2021 · 0 comments · Fixed by #415
Assignees
Labels
big issues Issues containing a lot of thought about an issue, often with unresolved next steps core domain Entities and core domain/business logic enhancement New feature or request
Milestone

Comments

@carlgieringer
Copy link
Contributor

carlgieringer commented Jul 14, 2021

Core question

  • Support multiple MediaExcerpts with the same quotation? (Improve MediaExcerpt equivalence calculation and support MediaExcerpt suggestions (see MediaExcerpts DAO))
    • Identical local reps with any overlapping Source/Locator should be equivalent
    • What if they have the same (or different) other localReps, such as screenshot?

Core feature

  • Create MediaExcerpts from mobile #430
  • Allow manual MediaExcerpt creation for creating justifications/appearances based on offline sources.
  • Integrations
    • Source page, including editing & list of MediaExcerpts.
    • Main search:
      • Search sources by description
      • Search MediaExcerpts by quotation
      • Search MediaExcerpts by URL
      • Search MediaExcerpts by domain
    • JustifiedProposition
    • See usages of MediaExcerpts (search Justifications and Appearances.)
    • Recent MediaExcerpts
  • Remove WritQuote from JustifiedProposition editor.
  • Support adding locators to an excerpt
    • How to display similar locators (same URL, different anchor)? Show one URL along with multiple icons to see the different anchors? Just show separately now because of the creator issue.
    • When the creator of the UrlLocator differs from the creator of the MediaExcerpt, show it next to that item.
  • Update the create MediaExcerpts endpoint both to confirm the quotation and to confirm or add DOM anchors to the UrlLocator (it's the localRep that needs confirmation, not the UrlLocator's anchors.)
    • We should store a timestamp when we successfully crawled a quotation so that we can display an icon locally indicating that it is confirmed to appear remotely.
  • Address that we can get multiple identical URLs for a ME in the UI if they have different text fragments.
  • Prepopulate the most popular Source description when creating a MediaExcerpt using a URL or domain with existing MediaExcerpts.
  • Improve text-fragment-to-quotation and quotation-to-text-fragment process #500

Cleanup

Moved to (#508)

Later improvements

Core features (done)

  • Add pincites, which are like an anchor for offline sources
  • Figure out how to model URL targets and anchors. (Possibly type extension first, Convert most of the browser extension to TypeScript #251, UrlTargetAnchor vs. TextQuoteAnchor.)
  • Convert source-related JS Components to TS:
    • ./src/EditableWrit.js
    • ./src/WritViewer.js
    • ./src/TextField.js
    • ./src/UrlTextField.js
    • ./src/SingleLineTextField.js
    • ./src/Link.js
    • ./src/Checkbox.js
    • ./src/CheckboxList.js what's this?
    • ./src/PropositionCard.js
    • ./src/PersorgViewer.js
    • ./src/PersorgEditor.js
    • ./src/PersorgEntityCard.js
    • ./src/EditablePersorg.js
    • ./src/WindowMessageHandler.js
@carlgieringer carlgieringer added enhancement New feature or request core domain Entities and core domain/business logic labels Jul 14, 2021
@carlgieringer carlgieringer added this to the P1 milestone Jul 14, 2021
@carlgieringer carlgieringer self-assigned this Oct 9, 2022
@carlgieringer carlgieringer linked a pull request May 26, 2023 that will close this issue
@carlgieringer carlgieringer mentioned this issue Jun 4, 2023
27 tasks
@github-project-automation github-project-automation bot moved this from Todo to Done in Add appearances Jun 7, 2023
@carlgieringer carlgieringer reopened this Jun 9, 2023
@carlgieringer carlgieringer moved this from Done to In Progress in Add appearances Aug 12, 2023
@carlgieringer carlgieringer modified the milestones: P1, P0 Sep 5, 2023
@carlgieringer carlgieringer added the big issues Issues containing a lot of thought about an issue, often with unresolved next steps label Jul 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
big issues Issues containing a lot of thought about an issue, often with unresolved next steps core domain Entities and core domain/business logic enhancement New feature or request
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

1 participant