Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MediaExcerpts #415

Merged
merged 7 commits into from
Jun 7, 2023
Merged

Add MediaExcerpts #415

merged 7 commits into from
Jun 7, 2023

Conversation

carlgieringer
Copy link
Contributor

@carlgieringer carlgieringer commented May 26, 2023 •
edited
Loading

  • Add react-material-symbols (fixes Improve iconography #416)
  • Add DEV_SERVER_LOCAL_NETWORK to support localhost vs. local IP web app serving
  • Fix '+ Howdju' from extension (now creates a MediaExcerpt.)
  • Add launch config for attaching to Node from VS Code
  • Add check that test DB dump is updated (bin/check-test-db-dump-updated.sh)
  • Add TestHelper

@carlgieringer carlgieringer linked an issue May 26, 2023 that may be closed by this pull request
Improve source handling #38
Open
45 tasks
github-advanced-security[bot]
github-advanced-security bot found potential problems May 26, 2023
View reviewed changes
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

@github-actions
Copy link

github-actions bot commented May 26, 2023 •
edited
Loading

Changed-files coverage summary


=============================== Coverage summary ===============================
Statements   : 50.83% ( 2244/4415 )
Branches     : 34.65% ( 728/2101 )
Functions    : 50.85% ( 477/938 )
Lines        : 57.7% ( 2125/3683 )
================================================================================

@carlgieringer carlgieringer force-pushed the features/20-support-appearances branch from 9180368 to 2340641 Compare May 26, 2023 06:48
@carlgieringer
Send AnchorInfo from extension to create justification
b207cb4 
Signed-off-by: Carl Gieringer <78054+carlgieringer@users.noreply.github.com>
@carlgieringer
Add MediaExcerpts
dbcf5c9 
Signed-off-by: Carl Gieringer <78054+carlgieringer@users.noreply.github.com>
@carlgieringer
Fix checks
5d1bb57 
Signed-off-by: Carl Gieringer <78054+carlgieringer@users.noreply.github.com>
@carlgieringer
Add MediaExcerptsPage, Add Service tests, fix extension
d83874d 
Signed-off-by: Carl Gieringer <78054+carlgieringer@users.noreply.github.com>
@carlgieringer
Improve do-not-merge check
e7561a7 
Signed-off-by: Carl Gieringer <78054+carlgieringer@users.noreply.github.com>
@carlgieringer carlgieringer force-pushed the features/20-support-appearances branch from 9dfbb56 to e7561a7 Compare June 4, 2023 17:26
@carlgieringer
Fix checks
87684f0 
Signed-off-by: Carl Gieringer <78054+carlgieringer@users.noreply.github.com>
@carlgieringer
PR edits
5ecb74f 
Signed-off-by: Carl Gieringer <78054+carlgieringer@users.noreply.github.com>
@carlgieringer carlgieringer added the requires schema release PRs that must update the database schema label Jun 7, 2023
@carlgieringer carlgieringer merged commit 207dfc7 into master Jun 7, 2023
@carlgieringer carlgieringer deleted the features/20-support-appearances branch June 7, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
requires schema release PRs that must update the database schema
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve source handling Improve iconography
1 participant
@carlgieringer