Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert input components to TS #398

Merged
merged 5 commits into from
Apr 23, 2023
Merged

Convert input components to TS #398

merged 5 commits into from
Apr 23, 2023

Conversation

carlgieringer
Copy link
Contributor

@carlgieringer carlgieringer commented Apr 23, 2023 •
edited
Loading

Related to #38 (comment)

Convert these to TS:

  • ./src/TextField.js
  • ./src/UrlTextField.js
  • ./src/SingleLineTextField.js
  • ./src/Link.js
  • ./src/Checkbox.js
  • ./src/CheckboxList.js

Also fix submitting a content report.

@carlgieringer
Convert TextInput to TS
09d7245 
Signed-off-by: Carl Gieringer <78054+carlgieringer@users.noreply.github.com>
@carlgieringer
Convert SingleLineTextField and UrlTextField to TS
627fcec 
Signed-off-by: Carl Gieringer <78054+carlgieringer@users.noreply.github.com>
@github-actions
Copy link

github-actions bot commented Apr 23, 2023 •
edited
Loading

Changed-files coverage summary


=============================== Coverage summary ===============================
Statements   : 65.9% ( 342/519 )
Branches     : 33.67% ( 66/196 )
Functions    : 46.76% ( 65/139 )
Lines        : 67.27% ( 337/501 )
================================================================================

@carlgieringer carlgieringer force-pushed the features/38-convert-input-components-to-TS branch 2 times, most recently from b199611 to 7a85441 Compare April 23, 2023 18:43
@carlgieringer
PR edits
d363d89 
Signed-off-by: Carl Gieringer <78054+carlgieringer@users.noreply.github.com>
@carlgieringer carlgieringer force-pushed the features/38-convert-input-components-to-TS branch from 7a85441 to d363d89 Compare April 23, 2023 18:53
@carlgieringer
Convert Link component to TS
4390a63 
Signed-off-by: Carl Gieringer <78054+carlgieringer@users.noreply.github.com>
@carlgieringer
Convert Checkbox/CheckboxList to TS and fix content reports
4b61132 
Signed-off-by: Carl Gieringer <78054+carlgieringer@users.noreply.github.com>
@carlgieringer carlgieringer changed the title Convert text input components to TS Convert input components to TS Apr 23, 2023
@carlgieringer carlgieringer merged commit bf53cb8 into master Apr 23, 2023
@carlgieringer carlgieringer deleted the features/38-convert-input-components-to-TS branch April 23, 2023 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@carlgieringer