Fix home grown JSON serialization #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlgieringer
force-pushed
the
features/circular-json-3
branch
2 times, most recently
from
cdd222d to
8be44f5
Compare
carlgieringer
changed the title
Changed-files coverage summary |
Signed-off-by: Carl Gieringer <78054+carlgieringer@users.noreply.github.com>
carlgieringer
force-pushed
the
features/circular-json-3
branch
from
8be44f5 to
f5daf4a
Compare
carlgieringer
commented
Jul 27, 2024
| @@ -91,7 +91,7 @@ const makeJsonLogArguments = function (logLevel, logLevelNumber, ...args) { | |||
| logRecord["data"] = data; | |||
| } | |||
|
|
|||
| const logRecordJson = toJson(logRecord, jsonStringifyReplacer); | |||
| const logRecordJson = JSON.stringify(logRecord, jsonStringifyReplacer); | |||
There was a problem hiding this comment.
I think this should have stayd as toJson to support circularity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
decircular didn't handle custom toJSON (like moment uses)