-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add auth refresh token #727
Conversation
Signed-off-by: Carl Gieringer <78054+carlgieringer@users.noreply.github.com>
078b131
to
d4e06b4
Compare
Signed-off-by: Carl Gieringer <78054+carlgieringer@users.noreply.github.com>
Changed-files coverage summary
|
Signed-off-by: Carl Gieringer <78054+carlgieringer@users.noreply.github.com>
Signed-off-by: Carl Gieringer <78054+carlgieringer@users.noreply.github.com>
baa588f
to
2482323
Compare
This PR addressed a security vulnerability where Howdju's authToken was persisted in browser localStorage, making it vulnerable to XSS. The new system uses an authRefreshToken, persisted as a secure http-only cookie, and protects the authToken from XSS: stored in-memory only and never accessible via a global JS object. The authRefreshToken is only recognized by the Some background on this approach is here. |
The changes to PasswordResetService fix password resets. The link includes in these emails previously was not URL-encoded, and so often would not be recognized by the server. |
Things to test: