Merge pull request #2200 from HubSpot/s3_uploader_client_efficiency

One additional null check in uploader client return
HubSpot · Apr 9, 2021 · 776efde · 776efde
2 parents fac6f07 + 4603b05
commit 776efde
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/SingularityS3Uploader/src/main/java/com/hubspot/singularity/s3uploader/S3ClientProvider.java b/SingularityS3Uploader/src/main/java/com/hubspot/singularity/s3uploader/S3ClientProvider.java
@@ -66,7 +66,7 @@ public void run() {
 
   public synchronized void tryRemoveClient(String key) {
     AtomicInteger holds = clientHolds.get(key);
-    if (holds.get() == 0) {
+    if (holds != null && holds.get() == 0) {
       clientHolds.remove(key);
       clientByKey.remove(key);
     }