Merge pull request #2119 from HubSpot/add-orderDirection

Add orderDirection param
HubSpot · Jul 17, 2020 · 7d53ef8 · 7d53ef8
2 parents 938c3c0 + ccc9363
commit 7d53ef8
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/SingularityClient/src/main/java/com/hubspot/singularity/client/SingularityClient.java b/SingularityClient/src/main/java/com/hubspot/singularity/client/SingularityClient.java
@@ -1674,6 +1674,8 @@ public void deleteSlave(String slaveId) {
    *    Long millis to filter request histories created before
    * @param createdAfter
    *    Long millis to filter request histories created after
+   * @param orderDirection
+   *    Sort order by createdAt
    * @param count
    *    Number of items to return per page
    * @param page
@@ -1685,6 +1687,7 @@ public Collection<SingularityRequestHistory> getHistoryForRequest(
     String requestId,
     Optional<Long> createdBefore,
     Optional<Long> createdAfter,
+    Optional<OrderDirection> orderDirection,
     Optional<Integer> count,
     Optional<Integer> page
   ) {
@@ -1703,6 +1706,10 @@ public Collection<SingularityRequestHistory> getHistoryForRequest(
       queryParamsBuilder.put("createdAfter", createdAfter.get());
     }
 
+    if (orderDirection.isPresent()) {
+      queryParamsBuilder.put("orderDirection", orderDirection.get());
+    }
+
     if (count.isPresent()) {
       queryParamsBuilder.put("count", count.get());
     }
@@ -1733,6 +1740,7 @@ public Collection<SingularityRequestHistory> getHistoryForRequest(
       requestId,
       Optional.empty(),
       Optional.empty(),
+      Optional.empty(),
       count,
       page
     );