Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No retry for scheduled tasks run on-demand through UI #1387

Merged
merged 4 commits into from
Jan 13, 2017
Merged

No retry for scheduled tasks run on-demand through UI #1387

merged 4 commits into from
Jan 13, 2017

Conversation

matush-v
Copy link
Contributor

Changes:

  • UI initiated 'run now' won't retry
  • Failed tasks aren't included in average task runtime

@tpetr

@tpetr
Copy link
Contributor

tpetr commented Dec 29, 2016

LGTM, thanks! Could you add a unittest to verify this, merge into hs_staging, test, then merge into hs_qa?

matush-v
matush-v commented Dec 29, 2016
View reviewed changes
...ularityService/src/test/java/com/hubspot/singularity/scheduler/SingularitySchedulerTest.java
resourceOffers();

SingularityTask task = taskManager.getActiveTasks().get(0);
statusUpdate(task, TaskState.TASK_FAILED);

Assert.assertEquals(cmdLinArgs, taskManager.getPendingTasks().get(0).getCmdLineArgsList());
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tpetr I should note that I changed this test since we no longer create a PendingTask as there is no more retrying

@ssalinas ssalinas modified the milestone: 0.14.0 Jan 3, 2017
@ssalinas ssalinas changed the title UI "Run Now" fixes No retry for scheduled tasks run on-demand through UI Jan 3, 2017
@matush-v matush-v merged commit b52f474 into master Jan 13, 2017
@matush-v matush-v deleted the on-demand-retry branch January 13, 2017 21:03
@tpetr tpetr removed hs_qa labels Jan 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.14.0
Development

Successfully merging this pull request may close these issues.
3 participants
@matush-v @tpetr @ssalinas