Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace existing global search with search from requests page #1415

Merged
merged 1 commit into from
Feb 13, 2017

Conversation

PtrTeixeira
Copy link
Contributor

Change from directly using the fuzzy search API provided by fuzzy to
the existing custom one used in the search bar on the Requests page.
This did preserve using the existing react-typeahead element, rather
than switching to the react-select element. This should make the
global search a little less helter-skelter in what it matches.

One thing that we lost in this switchover: highlighting of matched
characters. The search on the requests page doesn't use or emit that
data, so it no longer comes into the global search. We also aren't as
yet using the full potential of the global search - for example, you
can't search by the deploy user, and you can't toggle searching by
status.

/cc @ssalinas

Change from directly using the fuzzy search API provided by `fuzzy` to
the existing custom one used in the search bar on the Requests page.
This did preserve using the existing `react-typeahead` element, rather
than switching to the `react-select` element.

One thing that we lost in this switchover: highlighting of matched
characters. The search on the requests page doesn't use or emit that
data, so it no longer comes into the global search. We also aren't as
yet using the full potential of the global search - for example, you
can't search by the deploy user, and you can't toggle searching by
status.
@matush-v
Copy link
Contributor

matush-v commented Feb 7, 2017

Just a question. I saw that this updated search has a sub filter for task types ( SCHEDULED, ON_DEMAND, etc.). Will this be a possible global search query or is it part of the unused potential you mentioned?

@PtrTeixeira
Copy link
Contributor Author

At the moment, it's unused; those filters are used on the requests page search, but not on the global search.

@ssalinas
Copy link
Member

ssalinas commented Feb 7, 2017

@PtrTeixeira , The t search doesn't have the full range of state/type filters, I don't think we need to specify that field at all here. state: 'all' and the search input should be enough

@PtrTeixeira
Copy link
Contributor Author

filterSelector does a filter by the contents of subFilter against requestType; if subFilter is empty or undefined, it will remove everything from what it returns.

@ssalinas
Copy link
Member

ssalinas commented Feb 7, 2017

My mistake, I had thought that subFilter not present just skipped that filter. Let's give this a try in staging

@ssalinas ssalinas modified the milestone: 0.14.0 Feb 9, 2017
@ssalinas ssalinas merged commit e5fa771 into master Feb 13, 2017
@ssalinas ssalinas deleted the restrict-search-order branch February 13, 2017 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants