Replace existing global search with search from requests page #1415
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change from directly using the fuzzy search API provided by
fuzzy
tothe existing custom one used in the search bar on the Requests page.
This did preserve using the existing
react-typeahead
element, ratherthan switching to the
react-select
element. This should make theglobal search a little less helter-skelter in what it matches.
One thing that we lost in this switchover: highlighting of matched
characters. The search on the requests page doesn't use or emit that
data, so it no longer comes into the global search. We also aren't as
yet using the full potential of the global search - for example, you
can't search by the deploy user, and you can't toggle searching by
status.
/cc @ssalinas