Standardize on toString/hash/equals formats #1429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matush-v
reviewed
Feb 23, 2017
| if (numPorts != resources.numPorts) { | ||
| return false; | ||
| } | ||
| return Double.compare(resources.diskMb, diskMb) == 0; |
There was a problem hiding this comment.
is there a reason we broke this apart?
| return Objects.hash(createdAt, user, eventType, request, message); | ||
| } | ||
|
|
||
| @Override | ||
| public String toString() { | ||
| return "SingularityRequestHistory [createdAt=" + createdAt + ", user=" + user + ", eventType=" + eventType + ", request=" + request + ", message=" + message + "]"; | ||
| } |
There was a problem hiding this comment.
nit: should we switch this to:
"SingularityRequestHistory{" +
"createdAt=" + createdAt +
", user=" + user +
", eventType=" + eventType +
", request=" + request+
", message=" + message +
"}";
to keep the format consistent with the others? Looks like there are a few other places using [] and formatted differently
Standardize on toString/hash/equals formats further toString unification missed one more Fix toString outside of SingularityBase Fix toString outside of SingularityBase
|
Updated for comments, thanks @darcatron |
|
🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably long overdue, but there is a mix of guava, java.util, string concat, etc in our override methods. This changes all of them to java.util.Objects for equals/hashCode and plain string concat for toString. This way there won't be any conflicts when guava changes class/method names etc.
replaces #1425
/cc @stevenschlansker