Don't show logs panel if task never running #1503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a task is currently stopped and never reached the RUNNING state, don't show the "Logs" section, or include a link to "tail_of_finished_service.log".
Instead of showing a red label with "Task lost" when a task failed to start (eg, due to it attempting to accept an invalid offer), show a blue (info) label with the label "Task aborted."
ssalinas
reviewed
Apr 13, 2017
|
|
||
| const labelText = (status, currentState, cleanupType) => { | ||
| if (status === TaskStatus.NEVER_RAN) { | ||
| return 'Task aborted'; |
There was a problem hiding this comment.
👍 for this, I think this will make things a lot clearer for users
|
Good to go ahead and test in staging whenever you like @PtrTeixeira |
If the directory is linked directory is empty - either there never was anything there or whatever was there has now been cleaned up - don't show a link to the latest log on the task detail page.
Was previously checking the `length` property to determine if a given array had contents. This didn't work because in cases where the directory had been cleaned up, the query to get that field would respond with an error code, which resulted in `files` being `null` or `undefined`, rather than the empty array.
In some cases the whole object can be null, not just a field of it. This checks that the object is present before accessing its fields, which should hopefully prevent more exceptions from being thrown due to state oddities.
React requires that a component evaluate to either null, a dom element, or a react component when it renders. The `TaskLatestLog` component was rendering as `false`, rather than `null`, in cases when files were not loaded - in particular, when following links directly into a directory rather than the task page itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a task is currently stopped and never reached the RUNNING state,
don't show the "Logs" section, or include a link to
"tail_of_finished_service.log".