Write files in subdirectories to splat path #1513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the page was loaded the first time, the call to get the files to the directory wasn't being called with the directory splat. It was therefore always fetching the files from the top-level directory. When linked to the top level directory, this wasn't notable, but links into the subdirectory of the file browser would seem as if the directory was empty until going back to the root directory.
|
Gotta love when one missing variable can ruin the day... LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the page was loaded the first time, the call to get the files to
the directory wasn't being called with the directory splat. It was
therefore always fetching the files from the top-level directory. When
linked to the top level directory, this wasn't notable, but links into
the subdirectory of the file browser would seem as if the directory was
empty until going back to the root directory.