Include deploy marker and oldest deploy step in state #1516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matush-v
reviewed
Apr 26, 2017
| if (deployStepDelta > oldestDeployStep) { | ||
| oldestDeployStep = deployStepDelta; | ||
| } | ||
| } | ||
| long delta = now - pendingDeploy.getDeployMarker().getTimestamp(); | ||
| if (delta > oldestDeploy) { | ||
| oldestDeploy = delta; |
There was a problem hiding this comment.
not sure if I'm following the logic correctly here, but should this be in an else clause? Seems like we're calculating the delta twice and will get the longer time even if it's an incremental deploy
There was a problem hiding this comment.
two different deltas. I'm adding additional fields since it is likely some things still use the old oldestDeploy one, so still calculating that one as normal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @darcatron