Fix bug when 'maxTotalHealthcheckTimeout' set #1572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The comparison was flipped in the validator the max total healtheck timeout seconds, where when it was set it would reject anything _less_ than that period, rather than anything greater than it. We never noticed the bug because internally this isn't a field that we set.
|
👍 another that can go to staging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The comparison was flipped in the validator the max total health check
timeout seconds, where when it was set it would reject anything less
than that period, rather than anything greater than it. We never noticed
the bug because internally this isn't a field that we set.
/cc @ssalinas