Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating the alert banner to only show when there's a widespread issue #1877

Merged
merged 7 commits into from
Nov 20, 2018

Conversation

sjeropkipruto
Copy link
Contributor

@sjeropkipruto sjeropkipruto commented Nov 14, 2018

Currently, the UI shows a banner when only a small count of tasks are overdue (when max task lag is greater than 3 minutes). I'm updating the UI to show an alert banner only when there's a widespread issue (when the count of distinct requests with overdue tasks is greater than 10).

@sjeropkipruto sjeropkipruto self-assigned this Nov 14, 2018
SingularityUI/app/components/common/Application.jsx Outdated Show resolved Hide resolved
SingularityUI/app/utils.es6 Outdated Show resolved Hide resolved
@baconmania
Copy link
Contributor

🚢

@ssalinas ssalinas merged commit d87e9c1 into master Nov 20, 2018
@ssalinas ssalinas deleted the late-requests-banner branch November 20, 2018 16:08
@ssalinas ssalinas added this to the 0.22.0 milestone Dec 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants