Reduce S3Uploader memory usage during directory scan #1906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Confirmed fix in our QA env. uploader that previously grew to ~1600MB is now topping out at 13MB of heap |
|
🚢 |
|
🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our
JavaUtils. iterablefunction was previously taking a DirectoryStream -> Lists.newArrayList(stream.iterator()). This caused all paths in a directory to be in memory at once. For particularly large directories this was causing ooms in the uploader. Files.walk does this in more of a streaming fashion and should save us from loading the entire directory tree in memory before iterating over it