Cleaner failover + update dependencies #1908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… delay + include trace in abort email
|
notes:
|
baconmania
reviewed
Feb 21, 2019
| @@ -403,14 +424,25 @@ public SingularityPendingRequestParent scheduleImmediately(SingularityUser user, | |||
|
|
|||
| checkConflict(requestWithState.getState() != RequestState.PAUSED, "Request %s is paused. Unable to run now (it must be manually unpaused first)", requestWithState.getRequest().getId()); | |||
|
|
|||
| // Check these to avoid unnecessary calls to taskManager | |||
| Integer activeTasks = null; | |||
| Integer pendingTasks = null; | |||
There was a problem hiding this comment.
I think we want to default these to 0 instead of null to avoid NPE's in checkRunNowRequest().
|
🚢 |
|
🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This consolidates our many Managed classes and scheduled executor usages so we have clear control over the order in which they shut down (and make sure they all actually do...). This should help keep state more consistent on singularity failover. Ideally I'll add in the ability for Singulairty to not fail over for loss of mesos connection, and instead try to reconnect