Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework cooldown logic #1961

Merged
merged 6 commits into from
Jun 27, 2019
Merged

Rework cooldown logic #1961

merged 6 commits into from
Jun 27, 2019

Conversation

ssalinas
Copy link
Member

@ssalinas ssalinas commented Jun 20, 2019

We have found that Singularity's cooldown logic does not accurately capture cases like a slow failure loop, partially due to the fact that we purge out of the deploy statistics after only a minute or two. This reworks the cooldown logic to do a few things:

  • save all failures in the deploy statistics. Each is just a long, so not too worried about data size here
  • add a fast vs slow cooldown. In this case 3 failures in a minute or 5 failures in 10 minutes as a default

TODOs:

  • fix up unit tests
  • Figure out if it's still worth scaling this to instance count somehow

@ssalinas ssalinas changed the title WIP - Rework cooldown logic Rework cooldown logic Jun 21, 2019
@ssalinas ssalinas added the hs_qa label Jun 25, 2019
@pschoenfelder
Copy link
Contributor

🚢

@baconmania
Copy link
Contributor

🚢

@ssalinas ssalinas merged commit e7cee4a into master Jun 27, 2019
@ssalinas ssalinas deleted the cooldown_fix branch June 27, 2019 13:09
@ssalinas ssalinas added this to the 0.23.0 milestone Jun 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants