More performance updates #2034
More performance updates #2034
Conversation
|
Next round of updates:
|
|
latest additions:
|
| @@ -73,8 +72,7 @@ public SnsWebhookManager(@Singularity ObjectMapper objectMapper, | |||
| this.snsClient = AmazonSNSClientBuilder.defaultClient(); | |||
| } | |||
| this.webhookManager = webhookManager; | |||
| this.publishSemaphore = AsyncSemaphore.newBuilder(configuration::getMaxConcurrentWebhooks, executorServiceFactory.get("webhook-publish-semaphore", 1)).build(); | |||
| this.publishExecutor = managedCachedThreadPoolFactory.get("webhook-publish"); | |||
| this.publishExecutor = managedCachedThreadPoolFactory.get("webhook-publish", configuration.getMaxConcurrentWebhooks()); | |||
There was a problem hiding this comment.
Leaving a note here to double check our naming here, for both managedCachedThreadPoolFactory and maxConcurrentWebhooks
There was a problem hiding this comment.
did the rename for these. Going to leave the config var the same though for easier backwards compatibility. It is essentially still controlling the same thing, we are just being limited by the size of a fixed thread pool vs the async semaphore now. A future update could be to consolidate all the thread pool size configs in one spot
| statePoller.wake(); | ||
| scheduler.start(); |
There was a problem hiding this comment.
Small change, but I'm curious: why?
There was a problem hiding this comment.
If we call the state poller first we get instant feedback in the UI about who is leader versus having to wait until after startup is already finished to know which host gained leadership
|
🚢 |
more to come soon....