Properly reconnect after losing mesos master connection #2061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssalinas
changed the title
ssalinas
commented
Jan 28, 2020
| @@ -77,7 +77,7 @@ | |||
| private Optional<String> mesosUsername = Optional.empty(); | |||
| private Optional<String> mesosPassword = Optional.empty(); | |||
|
|
|||
| private long reconnectTimeoutMillis = 60000; | |||
| private long reconnectTimeoutMillis = 120000; | |||
There was a problem hiding this comment.
This is lengthened because the attempt time now takes into account the startup period, not just the time from POST -> subscribed event like it did before
|
🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix reconnects in a situation where all masters are temporarily unavailable. Currently if the reconnect ends up throwing a ConnectException in the subscriber thread, that calls onConnectException which, correctly, starts the process over again. However, because this is still synchronously called on the subscriber thread, when the reconnect tries to interrupt that thread, waiting for the join then throws an InterruptedException (because it is called from the same thread being interrupted)
Moving the reconnect to a separate thread should solve this problem. It is currently a single thread, as no more than one of them should be running at a time anyway