Force index for task history requests by host and start/update times #2105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Mentioned this to @baconmania , but documenting here as well. If we are adding something non-postgres-compatible, we should make this into an abstract method instead. It can be implemented only in the mysql version and essentially a no-op on the postgres side |
|
@baconmania will let you review here |
|
@fabatef can we get the merge conflicts resolved here at some point. Realized this one never actually made it through to stable |
…force-index-hostUpdatedAt
|
🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forces task history search queries to use the
hostUpadtedAtindex for requests that only specifyhostandstartedAt/updatedAtfields. These queries currently timeout intermittently since thehostUpdatedAtindex isn't consistently chosen by the optimizer.