Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn down some noisy logging #2166

Merged
merged 1 commit into from
Jan 14, 2021
Merged

Turn down some noisy logging #2166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions SingularityService/src/main/java/com/hubspot/singularity/data/TaskManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -784,11 +784,11 @@ public SingularityCreateResult saveTaskHistoryUpdate(
taskHistoryUpdate.getTaskId(),
taskHistoryUpdate.getTaskState()
);
LOG.info("Found existing history {}", maybeExisting);
LOG.debug("Found existing history {}", maybeExisting);
SingularityTaskHistoryUpdate updateWithPrevious;
if (maybeExisting.isPresent()) {
updateWithPrevious = taskHistoryUpdate.withPrevious(maybeExisting.get());
LOG.info("Will save new update {}", updateWithPrevious);
LOG.debug("Will save new update {}", updateWithPrevious);
} else {
updateWithPrevious = taskHistoryUpdate;
}
Expand Down
4 changes: 2 additions & 2 deletions ...e/src/main/java/com/hubspot/singularity/data/history/SingularityTaskHistoryPersister.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ public void runActionOnPoll() {
);
for (String requestId : requestIds) {
try {
LOG.info("Checking request {}", requestId);
LOG.debug("Checking request {}", requestId);
List<SingularityTaskId> taskIds = taskManager.getTaskIdsForRequest(requestId);
taskIds.removeAll(taskManager.getActiveTaskIdsForRequest(requestId));
taskIds.removeAll(taskManager.getLBCleanupTasks());
Expand All @@ -90,7 +90,7 @@ public void runActionOnPoll() {

forRequest++;
}
LOG.info(
LOG.debug(
"Transferred {} out of {} inactive task ids in {}",
transferred,
taskIds.size(),
Expand Down
4 changes: 2 additions & 2 deletions SingularityService/src/main/java/com/hubspot/singularity/helpers/RebalancingHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ public List<SingularityTaskId> rebalanceRacks(
Multiset<String> countPerRack = HashMultiset.create();
for (SingularityTaskId taskId : remainingActiveTasks) {
countPerRack.add(taskId.getRackId());
LOG.info(
LOG.debug(
"{} - {} - {} - {}",
countPerRack,
perRack,
Expand All @@ -68,7 +68,7 @@ public List<SingularityTaskId> rebalanceRacks(
taskId.getInstanceNo() > 1
) {
extraCleanedTasks.add(taskId);
LOG.info("Cleaning up task {} to evenly distribute tasks among racks", taskId);
LOG.debug("Cleaning up task {} to evenly distribute tasks among racks", taskId);
taskManager.createTaskCleanup(
new SingularityTaskCleanup(
user,
Expand Down
6 changes: 3 additions & 3 deletions ...tyService/src/main/java/com/hubspot/singularity/scheduler/SingularityUpstreamChecker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,15 +181,15 @@ private Collection<UpstreamInfo> getLoadBalancerUpstreamsForService(
singularityRequestId
);
try {
LOG.info(
LOG.trace(
"Sending request to get load balancer upstreams for service {} with loadBalancerServiceId {}.",
singularityRequestId,
loadBalancerServiceId
);
final SingularityCheckingUpstreamsUpdate checkUpstreamsState = lbClient.getLoadBalancerServiceStateForRequest(
loadBalancerServiceId
);
LOG.debug(
LOG.trace(
"Succeeded getting load balancer upstreams for singularity request {} with loadBalancerServiceId {}. State is {}.",
singularityRequestId,
loadBalancerServiceId,
Expand Down Expand Up @@ -357,7 +357,7 @@ private void checkSyncUpstreamsState(
.retryIfResult(IS_WAITING_STATE)
.build();
try {
LOG.info(
LOG.debug(
"Checking load balancer request to sync upstreams for service {} using a retryer until the request state is no longer waiting.",
singularityRequestId
);
Expand Down