Block reconciliation if queue nearly full #2185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosalind210
commented
Mar 4, 2021
...tyService/src/main/java/com/hubspot/singularity/scheduler/SingularityTaskReconciliation.java
Outdated
Show resolved
Hide resolved
rosalind210
commented
Mar 4, 2021
...tyService/src/main/java/com/hubspot/singularity/scheduler/SingularityTaskReconciliation.java
Outdated
Show resolved
Hide resolved
rosalind210
commented
Mar 4, 2021
...tyService/src/main/java/com/hubspot/singularity/scheduler/SingularityTaskReconciliation.java
Show resolved
Hide resolved
|
let's test in staging, but looks good 👍 . We can do something like shrink the queue size really small + make an example request and scale it to something ridiculous like 300 to hopefully trigger and see it in action |
rosalind210
commented
Mar 9, 2021
| @@ -647,4 +647,12 @@ public boolean hasRoomForMoreUpdates() { | |||
| statusUpdatesExecutor.getExecutorService() | |||
| ); | |||
| } | |||
|
|
|||
| public double getQueueFullness() { | |||
| LOG.info("Queue size: {}", statusUpdatesExecutor.getQueue().size()); | |||
There was a problem hiding this comment.
should I add more, like queue limit and the computation of queue fullness?
|
I tried adding unit tests, but the status queue was still processing them faster than I could run a reconciliation check so I wasn't able to hit the blocking conditional; and if I tried to create too many tasks, I was blocked by testing resources. |
|
🚢 |
|
🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the queue is nearly full, adding a number of tasks for reconciliation can put us into a loop of lag as the scheduler tries to go through tasks and more reconciliation attempts.