Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small one:
Bigger one:
Currently when a new leader takes over we can hit an order of events like the following:
We now have a case of a write for type X that made it to ZK, but not to the leader cache. This can result in missing deploy data, missing requests, requests that are present but actually were deleted, etc.
The new PR here adds an additional check within active() that should serve to block the calling thread when bootstrapping of the leader cache is still in progress. So, we will delay all incoming writes and wait for this to finish, rather than trying to reconcile state afterwards.
Would like feedback on the java-y bits here for sure: