Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore old constructor in singularity request parent #2247

Merged
merged 2 commits into from
Dec 6, 2021

Conversation

WH77
Copy link
Contributor

@WH77 WH77 commented Dec 6, 2021

Need to keep the old constructor for external code that creates request parent objects directly.

cc - @ssalinas

Copy link
Member

@ssalinas ssalinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deprecated constructor doesn't need all the JsonProperty annotations, gtg besides that

@ssalinas
Copy link
Member

ssalinas commented Dec 6, 2021

🚢

@WH77 WH77 merged commit bbb3e20 into master Dec 6, 2021
@WH77 WH77 deleted the fix-request-parent branch December 6, 2021 16:22
@ssalinas ssalinas added this to the 1.5.0 milestone May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants