Add decom reasons to task cleaning messages #2272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pschoenfelder
commented
Mar 7, 2022
Comment on lines
221
to
222
| // TODO: Is there a guaranteed order these come out of ZK in to prevent sort? | ||
| // Probably nbd because this list will be very short, but still |
There was a problem hiding this comment.
@ssalinas By any chance do you know this off the top of your head?
There was a problem hiding this comment.
will want to sort them here, I don't believe our agentManager provides any ordering
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task cleaning messages due to decom don't provide much context. Users often don't know to check the decommissioning agents page for reasons. Adding the decom message to the task cleaning update should help with this.