Address missing task data #2274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssalinas
changed the title
|
update here, found some additional pieces. Based on the logs and the fact that a regular task bounce (which uses getTask vs getTasks) succeeds. We can say the task data is in the zkCache, but not in zk itself. So, as a bandaid, this attempts to repair the task if we see that case, before continuing on to the methods that would throw exceptions. The overall flow should remain the same if the task is still not present |
WH77
approved these changes
Mar 17, 2022
SingularityService/src/main/java/com/hubspot/singularity/data/TaskManager.java
Show resolved
Hide resolved
...ularityService/src/main/java/com/hubspot/singularity/scheduler/SingularityDeployChecker.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are seeing some NPEs come through here. Adding more logging to see what is missing on the task definition here