Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify Node.js version for compatibility #100

Closed
esme opened this issue Apr 11, 2023 · 0 comments
Closed

Specify Node.js version for compatibility #100

esme opened this issue Apr 11, 2023 · 0 comments
Labels
dependencies Pull requests that update a dependency file

Comments

@esme
Copy link
Contributor

esme commented Apr 11, 2023

We should specify the minimum required Node.js version, by setting engines in the package.json file to the semantic versioning specification range that is compatible with calling-extensions-sdk without requiring --openssl-legacy-provider support.

Additionally, we should remove and gitignore existing .node-version files from the packages. While it is helpful in a local development setup, .node-version has yet to be adopted by nvm, and can potentially create noise for users who only require a minimum compatible version.

Related to discussion in #98 (comment)
@esme esme added the dependencies Pull requests that update a dependency file label Apr 11, 2023
@esme esme mentioned this issue Apr 24, 2023
Merged
1 task
@esme esme closed this as completed Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@esme