Specify minimum required Node.js version #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
alonso-cadenas
approved these changes
Apr 26, 2023
| "build:gh": "npm ci && cross-env NODE_ENV=production npm run build", | ||
| "serve": "node scripts/support_node_17+.js webpack serve", | ||
| "serve": "webpack serve", |
There was a problem hiding this comment.
- What are the use cases for the
serveand thestartcommand? - For the
startcommand, do we always want to build before serving? Asking because I thought the serve command would build.
There was a problem hiding this comment.
The serve command follows the latest documentation from https://github.com/webpack/webpack-dev-server. The serve command doesn't generate files in the dist folder however so we need to build in the start command.
There was a problem hiding this comment.
Yup, I'm more wondering when would someone run npm run serve vs npm run start? Trying to understand the need to have these two commands.
In the same token, why would someone need to generate files in the dist folder when starting/serving the app? Asking because building and serving are usually fulfill different needs.
There was a problem hiding this comment.
The difference would be being able to preview the dist folder files when starting the app vs serving. I had specified npm run serve to serve the index html from the dist folder where the files are built but I think it makes more sense to reference the public folder.
If we don't need to minify the files when starting the app, then the only difference between serve and start would be the --open command.
There was a problem hiding this comment.
Sorry if this is all very confusing!! The reason why I needed to build the files was so that we could serve the demo-minimal-js.html or demo-react-ts.html file that is generated using HtmlWebpackPlugin.
alonso-cadenas
added a commit
that referenced
this pull request
May 22, 2023
* Host demo app on GitHub Pages * Create demo app UI using React and TS (#63) * Create demo app UI using React and TS * Deploy demo apps to GH pages (#65) * Deploy React app to GitHub Pages * Set up webpack config and node scripts to output demo apps in common build folder * Configure gh-pages in calling-extensions-sdk * Setup a testing suite for the demo app (#68) * Set up unit test framework and automate tests * Deploy to gh pages automatically * Separate workflows for previews and deploys * Use npm ci * Add cross-env * Run test:serve with --watch * Add minimal phone number validation to keypad (#71) * Add minimal phone number validation to keypad * Add test * Update event console logging (#70) * Update event handling console log messages * Move logging to iframe manager * Demo console banner (#78) * Add developer console banner * Preview all branches with demo keyword * Close widget after saving call * Send additional call engagement properties in callCompletedData (#79) * Demo app icons (#84) * Add icons to demo app * Deploy from build folder * Add keypad to call actions * Backfill unit tests (#86) * Backfill unit tests * Fix createEngagement called twice (#87) * Fix after rebase * Offer both demo apps (#88) * Add fake number to the From Numbers dropdown (#93) * Add fake numbers to the From Number dropdown * Update demos to use latest sdk package version (#96) * Use latest package version * Temporarily comment out imports for local dev * Update patch dependencies * Make errorType import easier * Organize NPM scripts in the demo app (#95) * Organize NPM scripts in the demo app * Merge changes from master branch (#102) * Merge changes from master branch * Rename __tests__ to dist-test * Demo readme (#104) * Add documentation for demo widgets * Publish new alpha version (#105) * Use 0.0.15-alpha.1 --------- Co-authored-by: Alonso Cadenas <cadenas.alonso@gmail.com> * Rename demo widgets (#106) * Rename demo widgets * Fix demo app build warnings and iFrame uninitialized message (#107) * Fix build warnings and iFrame uninitialized message * Optimize config for dev or prod build * Send callStartTime in outgoingCall message (#108) * Send callStartTime in outgoingCall message * Specify minimum required Node.js version (#109) * Specify minimum required Node.js version to maintain compatibility with dependencies * Remove node_options * Remove demo folder * Update webpack config to serve static files from the public directory (#114) * Enforce order of events in demo minimal js (#113) * Enforce order of events in demo minimal js * Finalize new demo app documentation (#115) * Add missing events * Finalize demo app documentation * Update diction * Omit line number * Use new local value to install the demo widget (#117) * Use local value to install demo widget * Fix spacing * Fix spacing * Add ability to publish prerelease versions to npm (#118) * Simplify publish scripts and add prerelease scripts. * pre-releases should be published as alpha versions * 0.0.15-alpha.2 * 0.0.15-alpha.3 * 0.0.15-beta.0 * 0.1.0-0 * 0.1.0-alpha.0 * 0.1.0-beta.0 * prepatch already exists via alpha and beta commands * 0.1.0 * Enable github actions (#120) * Enable github actions * Use latest sdk version in demos * Set versions for demos * Update demo documentation (#121) * Update demo docs * Enable branch previews * test gha (#124) * test gha * Enable github action deploy previews * Revert "test gha" This reverts commit ca86ab0. --------- Co-authored-by: Esme Ling <esmelingyr@gmail.com> Co-authored-by: Esme <23175119+esme@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Jira Ticket: CALL-3406
#100
Merge Checklist
BRAVE Checklist