Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo scripts #95

Merged
merged 6 commits into from
Apr 7, 2023
Merged

Demo scripts #95

merged 6 commits into from
Apr 7, 2023

Conversation

esme
Copy link
Contributor

@esme esme commented Apr 4, 2023

Description

Jira Ticket: CALL-3266

Now that we have a demos folder, we should organize the NPM scripts as a prerequisite to the JIRA ticket to update SDK npm dependencies and webpack build.

  • Move relevant scripts and index.html file to folder
  • Update working directory for GH actions
  • Serve the build folder within the demos directory on GH pages homepage

Merge Checklist

Q A
Adds Documentation?
Any Dependency Changes?
Patch: Bug Fix?
Minor: New Feature?
Major: Breaking Change?

BRAVE Checklist

  • I have read the BRAVE checklist and confirmed if the following is necessary.
Q A
Backwards Compatible?
Rollout/Rollback Plan?
Automated test coverage?
Verified that changes work? ✅ Build passes in https://github.com/HubSpot/calling-extensions-sdk/actions/runs/4602618763/jobs/8131785679
Expect Dependencies to Fail?

@esme esme changed the base branch from master to project-demo-v1 April 4, 2023 00:09
@esme esme marked this pull request as ready for review April 4, 2023 00:12
@esme esme requested a review from a team as a code owner April 4, 2023 00:12
@github-actions
Copy link

github-actions bot commented Apr 4, 2023

PR Preview Action v1.3.0
🚀 Deployed preview to https://HubSpot.github.io/calling-extensions-sdk/pr-preview/pr-95/
on branch gh-pages at 2023-04-04 00:27 UTC

demos/package.json Show resolved Hide resolved
demos/package.json Show resolved Hide resolved
demos/package.json Outdated Show resolved Hide resolved
@esme esme requested a review from alonso-cadenas April 5, 2023 16:39
Copy link
Collaborator

@alonso-cadenas alonso-cadenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thank you for enabling continuous deployments!

@esme esme merged commit 7ed9d80 into project-demo-v1 Apr 7, 2023
@esme esme deleted the demo-scripts branch April 7, 2023 21:09
alonso-cadenas added a commit that referenced this pull request May 22, 2023
* Host demo app on GitHub Pages

* Create demo app UI using React and TS (#63)

* Create demo app UI using React and TS

* Deploy demo apps to GH pages (#65)

* Deploy React app to GitHub Pages

* Set up webpack config and node scripts to output demo apps in common build folder

* Configure gh-pages in calling-extensions-sdk

* Setup a testing suite for the demo app (#68)

* Set up unit test framework and automate tests

* Deploy to gh pages automatically

* Separate workflows for previews and deploys

* Use npm ci

* Add cross-env

* Run test:serve with --watch

* Add minimal phone number validation to keypad (#71)

* Add minimal phone number validation to keypad

* Add test

* Update event console logging (#70)

* Update event handling console log messages

* Move logging to iframe manager

* Demo console banner (#78)

* Add developer console banner

* Preview all branches with demo keyword

* Close widget after saving call

* Send additional call engagement properties in callCompletedData (#79)

* Demo app icons (#84)

* Add icons to demo app

* Deploy from build folder

* Add keypad to call actions

* Backfill unit tests (#86)

* Backfill unit tests

* Fix createEngagement called twice (#87)

* Fix after rebase

* Offer both demo apps (#88)

* Add fake number to the From Numbers dropdown (#93)

* Add fake numbers to the From Number dropdown

* Update demos to use latest sdk package version (#96)

* Use latest package version

* Temporarily comment out imports for local dev

* Update patch dependencies

* Make errorType import easier

* Organize NPM scripts in the demo app (#95)

* Organize NPM scripts in the demo app

* Merge changes from master branch (#102)

* Merge changes from master branch

* Rename __tests__ to dist-test

* Demo readme (#104)

* Add documentation for demo widgets

* Publish new alpha version (#105)

* Use 0.0.15-alpha.1

---------

Co-authored-by: Alonso Cadenas <cadenas.alonso@gmail.com>

* Rename demo widgets (#106)

* Rename demo widgets

* Fix demo app build warnings and iFrame uninitialized message (#107)

* Fix build warnings and iFrame uninitialized message

* Optimize config for dev or prod build

* Send callStartTime in outgoingCall message (#108)

* Send callStartTime in outgoingCall message

* Specify minimum required Node.js version (#109)

* Specify minimum required Node.js version to maintain compatibility with dependencies

* Remove node_options

* Remove demo folder

* Update webpack config to serve static files from the public directory (#114)

* Enforce order of events in demo minimal js (#113)

* Enforce order of events in demo minimal js

* Finalize new demo app documentation (#115)

* Add missing events

* Finalize demo app documentation

* Update diction

* Omit line number

* Use new local value to install the demo widget (#117)

* Use local value to install demo widget

* Fix spacing

* Fix spacing

* Add ability to publish prerelease versions to npm (#118)

* Simplify publish scripts and add prerelease scripts.

* pre-releases should be published as alpha versions

* 0.0.15-alpha.2

* 0.0.15-alpha.3

* 0.0.15-beta.0

* 0.1.0-0

* 0.1.0-alpha.0

* 0.1.0-beta.0

* prepatch already exists via alpha and beta commands

* 0.1.0

* Enable github actions (#120)

* Enable github actions

* Use latest sdk version in demos

* Set versions for demos

* Update demo documentation (#121)

* Update demo docs

* Enable branch previews

* test gha (#124)

* test gha

* Enable github action deploy previews

* Revert "test gha"

This reverts commit ca86ab0.

---------

Co-authored-by: Esme Ling <esmelingyr@gmail.com>
Co-authored-by: Esme <23175119+esme@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants