Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy demo apps to GH pages #65

Merged
merged 6 commits into from
Feb 15, 2023
Merged

Deploy demo apps to GH pages #65

merged 6 commits into from
Feb 15, 2023

Conversation

esme
Copy link
Contributor

@esme esme commented Feb 15, 2023 •
edited
Loading

Description

Jira Ticket: CALL-3006

Deployed on GH Pages: https://github.hubspot.com/calling-extensions-sdk

Build folder structure

build
  - demo.html
  - demo.bundle.js
  - demo-v1.html
  - demo-v1.bundle.js
  - index.html

To build files: npm run build:demos
To deploy to gh-pages: npm run deploy

Testing

Merge Checklist

  • Does not introduce new console warnings
  • Adds/refactors unit tests
  • Adds/refactors integration tests
  • Adds/refactors acceptance tests
  • Adds documentation

@esme esme changed the base branch from master to project-demo-v1 February 15, 2023 20:17
@esme esme marked this pull request as ready for review February 15, 2023 20:18
@esme esme requested a review from a team as a code owner February 15, 2023 20:18
alonso-cadenas
alonso-cadenas reviewed Feb 15, 2023
View reviewed changes
demo-v1/package.json Outdated
"build": "webpack",
"start": "npm i && webpack-dev-server --open"
"build": "webpack && cp -a dist/. ../build",
"start": "yarn install && webpack-dev-server --open"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any particular reason for switching from npm to yarn to install dependencies?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been using yarn for the demo-v1 app to be consistent with our internal dependency management tool though npm works too.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, let's keep it npm for the time being until we do the monorepo setup!

@esme esme merged commit 36b66db into project-demo-v1 Feb 15, 2023
@esme esme deleted the gh-deploy branch February 15, 2023 22:40
esme added a commit that referenced this pull request Feb 16, 2023
@esme
Deploy demo apps to GH pages (#65)
501199c 
* Deploy React app to GitHub Pages

* Set up webpack config and node scripts to output demo apps in common build folder

* Configure gh-pages in calling-extensions-sdk
esme added a commit that referenced this pull request Mar 16, 2023
@esme
Deploy demo apps to GH pages (#65)
e756df5 
* Deploy React app to GitHub Pages

* Set up webpack config and node scripts to output demo apps in common build folder

* Configure gh-pages in calling-extensions-sdk
esme added a commit that referenced this pull request Mar 16, 2023
@esme
Deploy demo apps to GH pages (#65)
106af3a 
* Deploy React app to GitHub Pages

* Set up webpack config and node scripts to output demo apps in common build folder

* Configure gh-pages in calling-extensions-sdk
esme added a commit that referenced this pull request Mar 16, 2023
@esme
Deploy demo apps to GH pages (#65)
dfda928 
* Deploy React app to GitHub Pages

* Set up webpack config and node scripts to output demo apps in common build folder

* Configure gh-pages in calling-extensions-sdk
esme added a commit that referenced this pull request Apr 3, 2023
@esme
Deploy demo apps to GH pages (#65)
9e6f1da 
* Deploy React app to GitHub Pages

* Set up webpack config and node scripts to output demo apps in common build folder

* Configure gh-pages in calling-extensions-sdk
alonso-cadenas added a commit that referenced this pull request May 22, 2023
@alonso-cadenas @esme
Release new demo app and SDK improvements. (#119)
d108746 
* Host demo app on GitHub Pages

* Create demo app UI using React and TS (#63)

* Create demo app UI using React and TS

* Deploy demo apps to GH pages (#65)

* Deploy React app to GitHub Pages

* Set up webpack config and node scripts to output demo apps in common build folder

* Configure gh-pages in calling-extensions-sdk

* Setup a testing suite for the demo app (#68)

* Set up unit test framework and automate tests

* Deploy to gh pages automatically

* Separate workflows for previews and deploys

* Use npm ci

* Add cross-env

* Run test:serve with --watch

* Add minimal phone number validation to keypad (#71)

* Add minimal phone number validation to keypad

* Add test

* Update event console logging (#70)

* Update event handling console log messages

* Move logging to iframe manager

* Demo console banner (#78)

* Add developer console banner

* Preview all branches with demo keyword

* Close widget after saving call

* Send additional call engagement properties in callCompletedData (#79)

* Demo app icons (#84)

* Add icons to demo app

* Deploy from build folder

* Add keypad to call actions

* Backfill unit tests (#86)

* Backfill unit tests

* Fix createEngagement called twice (#87)

* Fix after rebase

* Offer both demo apps (#88)

* Add fake number to the From Numbers dropdown (#93)

* Add fake numbers to the From Number dropdown

* Update demos to use latest sdk package version (#96)

* Use latest package version

* Temporarily comment out imports for local dev

* Update patch dependencies

* Make errorType import easier

* Organize NPM scripts in the demo app (#95)

* Organize NPM scripts in the demo app

* Merge changes from master branch (#102)

* Merge changes from master branch

* Rename __tests__ to dist-test

* Demo readme (#104)

* Add documentation for demo widgets

* Publish new alpha version (#105)

* Use 0.0.15-alpha.1

---------

Co-authored-by: Alonso Cadenas <cadenas.alonso@gmail.com>

* Rename demo widgets (#106)

* Rename demo widgets

* Fix demo app build warnings and iFrame uninitialized message (#107)

* Fix build warnings and iFrame uninitialized message

* Optimize config for dev or prod build

* Send callStartTime in outgoingCall message (#108)

* Send callStartTime in outgoingCall message

* Specify minimum required Node.js version (#109)

* Specify minimum required Node.js version to maintain compatibility with dependencies

* Remove node_options

* Remove demo folder

* Update webpack config to serve static files from the public directory (#114)

* Enforce order of events in demo minimal js (#113)

* Enforce order of events in demo minimal js

* Finalize new demo app documentation (#115)

* Add missing events

* Finalize demo app documentation

* Update diction

* Omit line number

* Use new local value to install the demo widget (#117)

* Use local value to install demo widget

* Fix spacing

* Fix spacing

* Add ability to publish prerelease versions to npm (#118)

* Simplify publish scripts and add prerelease scripts.

* pre-releases should be published as alpha versions

* 0.0.15-alpha.2

* 0.0.15-alpha.3

* 0.0.15-beta.0

* 0.1.0-0

* 0.1.0-alpha.0

* 0.1.0-beta.0

* prepatch already exists via alpha and beta commands

* 0.1.0

* Enable github actions (#120)

* Enable github actions

* Use latest sdk version in demos

* Set versions for demos

* Update demo documentation (#121)

* Update demo docs

* Enable branch previews

* test gha (#124)

* test gha

* Enable github action deploy previews

* Revert "test gha"

This reverts commit ca86ab0.

---------

Co-authored-by: Esme Ling <esmelingyr@gmail.com>
Co-authored-by: Esme <23175119+esme@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alonso-cadenas alonso-cadenas alonso-cadenas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@esme @alonso-cadenas