Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs with hs owned engagements event handlers #154

Merged
merged 8 commits into from
Oct 31, 2023
Merged

Update docs with hs owned engagements event handlers #154

merged 8 commits into from
Oct 31, 2023

Conversation

esme
Copy link
Contributor

@esme esme commented Oct 26, 2023

Description

Jira Ticket: CALL-5011

Merge Checklist

Q A
Adds Documentation? yes
Any Dependency Changes?
Patch: Bug Fix?
Minor: New Feature?
Major: Breaking Change?

BRAVE Checklist

  • I have read the BRAVE checklist and confirmed if the following is necessary.
Q A
Backwards Compatible?
Rollout/Rollback Plan?
Automated test coverage?
Verified that changes work?
Expect Dependencies to Fail?

@esme esme requested a review from a team as a code owner October 26, 2023 21:51
jmp3833
jmp3833 approved these changes Oct 26, 2023
View reviewed changes
Copy link

@jmp3833 jmp3833 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @esme

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@github-actions
Copy link

PR Preview Action v1.4.4
🚀 Deployed preview to https://HubSpot.github.io/calling-extensions-sdk/pr-preview/pr-154/
on branch gh-pages at 2023-10-30 19:48 UTC

jmp3833
jmp3833 approved these changes Oct 30, 2023
View reviewed changes
Copy link

@jmp3833 jmp3833 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @esme - thanks for bumping the SDK version here as well

@esme esme merged commit 4d7d2b4 into master Oct 31, 2023
1 check passed
@esme esme deleted the hs-owned-engagement-readme branch October 31, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmp3833 jmp3833 jmp3833 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@esme @jmp3833