Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix onReady event in the demo react widget #195

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Fix onReady event in the demo react widget #195

merged 1 commit into from
Apr 23, 2024

Conversation

esme
Copy link
Contributor

@esme esme commented Apr 23, 2024 •
edited
Loading

Description

Jira Ticket: CALL-6290

This fixes changes in #193 that broke the React Demo widget.

Merge Checklist

Q A
Adds Documentation?
Any Dependency Changes?
Patch: Bug Fix? yes
Minor: New Feature?
Major: Breaking Change?

BRAVE Checklist

  • I have read the BRAVE checklist and confirmed if the following is necessary.
Q A
Backwards Compatible?
Rollout/Rollback Plan?
Automated test coverage?
Verified that changes work?
Expect Dependencies to Fail?

@github-actions GitHub Actions
Copy link

PR Preview Action v1.4.7
🚀 Deployed preview to https://HubSpot.github.io/calling-extensions-sdk/pr-preview/pr-195/
on branch gh-pages at 2024-04-23 16:37 UTC

@alonso-cadenas alonso-cadenas marked this pull request as ready for review April 23, 2024 16:40
@alonso-cadenas alonso-cadenas requested a review from a team as a code owner April 23, 2024 16:40
@alonso-cadenas alonso-cadenas merged commit 1d60ce3 into master Apr 23, 2024
1 check passed
@alonso-cadenas alonso-cadenas deleted the CALL-6290-demo-react branch April 23, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alonso-cadenas alonso-cadenas alonso-cadenas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@esme @alonso-cadenas