Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the callStatus to canceled when we end an incoming call #199

Merged
merged 2 commits into from
May 8, 2024
Merged

Update the callStatus to canceled when we end an incoming call #199

merged 2 commits into from
May 8, 2024

Conversation

esme
Copy link
Contributor

@esme esme commented May 7, 2024 •
edited
Loading

Description

Jira Ticket: CALL-6484

Update the callStatus to canceled in the React demo widget when we cancel an incoming call instead of answering it.

Merge Checklist

Q A
Adds Documentation?
Any Dependency Changes?
Patch: Bug Fix? yes
Minor: New Feature?
Major: Breaking Change?

BRAVE Checklist

  • I have read the BRAVE checklist and confirmed if the following is necessary.
Q A
Backwards Compatible?
Rollout/Rollback Plan?
Automated test coverage?
Verified that changes work?
Expect Dependencies to Fail?

@github-actions GitHub Actions
Copy link

github-actions bot commented May 7, 2024

PR Preview Action v1.4.7
🚀 Deployed preview to https://HubSpot.github.io/calling-extensions-sdk/pr-preview/pr-199/
on branch gh-pages at 2024-05-07 19:00 UTC

@esme esme marked this pull request as ready for review May 7, 2024 22:39
@esme esme requested a review from a team as a code owner May 7, 2024 22:39
hemang-thakkar
hemang-thakkar approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@hemang-thakkar hemang-thakkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 🚀

@esme esme merged commit 856a8b2 into master May 8, 2024
1 check passed
@esme esme deleted the CALL-6484-canceled branch May 8, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hemang-thakkar hemang-thakkar hemang-thakkar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@esme @hemang-thakkar