Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toggle to enforce order of events in the demo minimal js #203

Merged
merged 2 commits into from
Aug 5, 2024

Conversation

esme
Copy link
Contributor

@esme esme commented May 22, 2024

Description

Jira Ticket: CALL-6601

Use state.enforceButtonsOrder to enforce order of events in the demo minimal js. It is set to false by default. This enables us to test asynchronous SDK events for inbound calling.

Merge Checklist

Q A
Adds Documentation?
Any Dependency Changes?
Patch: Bug Fix? yes
Minor: New Feature?
Major: Breaking Change?

BRAVE Checklist

  • I have read the BRAVE checklist and confirmed if the following is necessary.
Q A
Backwards Compatible?
Rollout/Rollback Plan?
Automated test coverage?
Verified that changes work?
Expect Dependencies to Fail?

Copy link

github-actions bot commented May 22, 2024

PR Preview Action v1.4.7
🚀 Deployed preview to https://HubSpot.github.io/calling-extensions-sdk/pr-preview/pr-203/
on branch gh-pages at 2024-08-05 22:27 UTC

@esme esme marked this pull request as ready for review May 22, 2024 19:01
@esme esme requested a review from a team as a code owner May 22, 2024 19:01
@hemang-thakkar
Copy link
Contributor

Would it be helpful if we add a button to toggle enforceButtonsOrder instead of doing thru console? just for easy testing

@esme esme requested a review from hemang-thakkar May 29, 2024 02:16
@alonso-cadenas
Copy link
Contributor

@esme checking in on the status of this PR.

@esme
Copy link
Contributor Author

esme commented Jul 18, 2024

As this supports a specific use case that isn't directly related to the CTI experience, could we follow up with a developer interface if needed?

@esme
Copy link
Contributor Author

esme commented Aug 2, 2024

@hemang-thakkar Let me know if this PR is good to go!

@esme esme merged commit ccc3b25 into master Aug 5, 2024
1 check passed
@esme esme deleted the enforce-buttons-order branch August 5, 2024 22:30
esme added a commit that referenced this pull request Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants