Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send ownerId in onReady event #209

Merged
merged 3 commits into from
Aug 5, 2024
Merged

Send ownerId in onReady event #209

merged 3 commits into from
Aug 5, 2024

Conversation

esme
Copy link
Contributor

@esme esme commented Aug 2, 2024 •
edited
Loading

Description

Jira Ticket: CALL-6409

Send ownerId in onReady event for Zoom.

Merge Checklist

Q A
Adds Documentation?
Any Dependency Changes?
Patch: Bug Fix?
Minor: New Feature? yes
Major: Breaking Change?

BRAVE Checklist

  • I have read the BRAVE checklist and confirmed if the following is necessary.
Q A
Backwards Compatible?
Rollout/Rollback Plan?
Automated test coverage?
Verified that changes work?
Expect Dependencies to Fail?

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 2, 2024 •
edited
Loading

PR Preview Action v1.4.7
🚀 Deployed preview to https://HubSpot.github.io/calling-extensions-sdk/pr-preview/pr-209/
on branch gh-pages at 2024-08-05 18:57 UTC

@esme esme marked this pull request as ready for review August 5, 2024 16:31
@esme esme requested a review from a team as a code owner August 5, 2024 16:31
@alonso-cadenas
Copy link
Collaborator

@esme I'd classify this change as a minor version improvement vs patch since the ownerId was never expected before.

@esme
Copy link
Contributor Author

esme commented Aug 5, 2024

@alonso-cadenas In this case, should I run publish:alpha:minor instead of publish:alpha?

@alonso-cadenas
Copy link
Collaborator

@esme Yup!

@esme esme merged commit f0291ad into master Aug 5, 2024
1 check passed
@esme esme deleted the CALL-6409 branch August 5, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alonso-cadenas alonso-cadenas alonso-cadenas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@esme @alonso-cadenas