Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CALL-6780: Update jsdocs and typedefs to make callId deprecated #222

Merged
merged 22 commits into from
Sep 10, 2024

Conversation

hemang-thakkar
Copy link
Contributor

@hemang-thakkar hemang-thakkar commented Sep 6, 2024

Description

Jira Ticket: CALL-6780

This PR aims at adding typedefs for calling-extensions-sdk code along with publishing d.ts files in package so that consumers can use the types for type validation. This also aims at improving code documentation.

Merge Checklist

Q A
Adds Documentation?
Any Dependency Changes?
Patch: Bug Fix?
Minor: New Feature?
Major: Breaking Change?

BRAVE Checklist

  • I have read the BRAVE checklist and confirmed if the following is necessary.
Q A
Backwards Compatible?
Rollout/Rollback Plan?
Automated test coverage?
Verified that changes work?
Expect Dependencies to Fail?

@hemang-thakkar hemang-thakkar requested a review from a team as a code owner September 6, 2024 16:03
Copy link
Collaborator

@alonso-cadenas alonso-cadenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! This is exactly what we need to in order to request developer docs updates.

src/CallingExtensions.js Show resolved Hide resolved
src/CallingExtensions.js Show resolved Hide resolved
src/typedefs.js Outdated Show resolved Hide resolved
src/typedefs.js Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Sep 9, 2024

PR Preview Action v1.4.7
🚀 Deployed preview to https://HubSpot.github.io/calling-extensions-sdk/pr-preview/pr-222/
on branch gh-pages at 2024-09-10 18:13 UTC

Copy link
Contributor

@esme esme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! 🥳

Copy link
Collaborator

@alonso-cadenas alonso-cadenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!!!

demos/demo-react-ts/src/hooks/useCti.ts Outdated Show resolved Hide resolved
src/IFrameManager.js Outdated Show resolved Hide resolved
@hemang-thakkar hemang-thakkar merged commit e0986d1 into master Sep 10, 2024
1 check passed
@hemang-thakkar hemang-thakkar deleted the CALL-6780 branch September 10, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants