Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add set widget url button to demo minimal js for testing #234

Merged
merged 5 commits into from
Oct 7, 2024
Merged

Add set widget url button to demo minimal js for testing #234

merged 5 commits into from
Oct 7, 2024

Conversation

esme
Copy link
Contributor

@esme esme commented Oct 3, 2024 •
edited
Loading

Description

https://github.com/HubSpot/calling-extensions-sdk/issues/230

Add setWidgetUrl button to demo minimal js to facilitate testing.
Re-initialize CTI.
image

Merge Checklist

Q A
Adds Documentation?
Any Dependency Changes?
Patch: Bug Fix? yes
Minor: New Feature?
Major: Breaking Change?

BRAVE Checklist

  • I have read the BRAVE checklist and confirmed if the following is necessary.
Q A
Backwards Compatible? yes
Rollout/Rollback Plan?
Automated test coverage?
Verified that changes work?
Expect Dependencies to Fail?

@esme esme requested a review from a team as a code owner October 3, 2024 20:42
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 3, 2024 •
edited
Loading

PR Preview Action v1.4.8
🚀 Deployed preview to https://HubSpot.github.io/calling-extensions-sdk/pr-preview/pr-234/
on branch gh-pages at 2024-10-07 04:08 UTC

@esme esme merged commit 99f3f6d into master Oct 7, 2024
1 check passed
@esme esme deleted the CALLING-12288 branch October 7, 2024 04:15
@esme esme mentioned this pull request Oct 8, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alonso-cadenas alonso-cadenas alonso-cadenas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@esme @alonso-cadenas