Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add isAvailable to SDK event #246

Merged
merged 5 commits into from
Jan 7, 2025
Merged

Add isAvailable to SDK event #246

merged 5 commits into from
Jan 7, 2025

Conversation

esme
Copy link
Contributor

@esme esme commented Dec 18, 2024 •
edited
Loading

Description

https://git.hubteam.com/HubSpot/calling-extensions-fe/issues/736

Set isLoggedIn and isAvailable to true for demo minimal js.

Merge Checklist

Q A
Adds Documentation?
Any Dependency Changes?
Patch: Bug Fix? x
Minor: New Feature?
Major: Breaking Change?

BRAVE Checklist

  • I have read the BRAVE checklist and confirmed if the following is necessary.
Q A
Backwards Compatible?
Rollout/Rollback Plan?
Automated test coverage?
Verified that changes work?
Expect Dependencies to Fail?

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 2, 2025 •
edited
Loading

PR Preview Action v1.4.8
🚀 Deployed preview to https://HubSpot.github.io/calling-extensions-sdk/pr-preview/pr-246/
on branch gh-pages at 2025-01-07 01:02 UTC

@esme esme marked this pull request as ready for review January 2, 2025 17:56
@esme esme requested a review from a team as a code owner January 2, 2025 17:56
@esme esme requested a review from hemang-thakkar January 6, 2025 19:56
hemang-thakkar
hemang-thakkar approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@hemang-thakkar hemang-thakkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@esme esme merged commit 3bd16b7 into master Jan 7, 2025
1 check passed
@esme esme deleted the is-available branch January 7, 2025 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hemang-thakkar hemang-thakkar hemang-thakkar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@esme @hemang-thakkar