Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrating src files to typescript and adding types #253

Merged
merged 9 commits into from
Jan 13, 2025

Conversation

hemang-thakkar
Copy link
Contributor

Description

Jira Ticket: CALL-xxxx

Merge Checklist

Q A
Adds Documentation?
Any Dependency Changes?
Patch: Bug Fix?
Minor: New Feature?
Major: Breaking Change?

BRAVE Checklist

  • I have read the BRAVE checklist and confirmed if the following is necessary.
Q A
Backwards Compatible?
Rollout/Rollback Plan?
Automated test coverage?
Verified that changes work?
Expect Dependencies to Fail?

@hemang-thakkar hemang-thakkar self-assigned this Jan 7, 2025
@hemang-thakkar hemang-thakkar requested a review from a team as a code owner January 7, 2025 17:55
@hemang-thakkar hemang-thakkar marked this pull request as draft January 7, 2025 17:55
@hemang-thakkar hemang-thakkar marked this pull request as ready for review January 10, 2025 20:15
Copy link

PR Preview Action v1.6.0

🚀 View preview at
https://HubSpot.github.io/calling-extensions-sdk/pr-preview/pr-253/

Built to branch gh-pages at 2025-01-10 20:36 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

tsconfig.json Show resolved Hide resolved
Copy link
Contributor

@esme esme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thanks for converting files to TS! Could we request a calling-extensions-sdk@1 repackage to test backwards compatibility?

package.json Outdated Show resolved Hide resolved
Copy link
Contributor

@alonso-cadenas alonso-cadenas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bravo 👏

@hemang-thakkar
Copy link
Contributor Author

@alonso-cadenas @esme how do i test it with sdk-test-app?

@hemang-thakkar
Copy link
Contributor Author

@alonso-cadenas @esme how do i test it with sdk-test-app?

Do we need repackage for testing?

@alonso-cadenas
Copy link
Contributor

@alonso-cadenas @esme how do i test it with sdk-test-app?

Do we need repackage for testing?

Yes, exactly. A repackage request must be submitted and then the ATs can be run.

@hemang-thakkar
Copy link
Contributor Author

@alonso-cadenas @esme how do i test it with sdk-test-app?

Do we need repackage for testing?

Yes, exactly. A repackage request must be submitted and then the ATs can be run.

That can be done once changes are merged. right?

@hemang-thakkar hemang-thakkar merged commit 5fe2c46 into master Jan 13, 2025
1 check passed
@hemang-thakkar hemang-thakkar deleted the ts-migration-fp branch January 13, 2025 19:43
@SammySamer
Copy link

SammySamer commented Jan 15, 2025

It seems the change to dist/main.js (and dist/main.esm.js) bricks installing through CDN (jsDeliver). If this is intended, please update the calling-extension-sdk documentation.
Edit: to clarify, the last functional version that can be correctly CDN installed is 0.8.3

@hemang-thakkar
Copy link
Contributor Author

@SammySamer I am able to load sdk through this url. https://cdn.jsdelivr.net/npm/@hubspot/calling-extensions-sdk@0.9.0/dist/main.js
Can you share what error are you getting?

@SammySamer
Copy link

@hemang-thakkar We've tried using the proposed URL, but it doesn't seem like we are able to access the sdk's functions anymore.
On 0.8.3 and before, it would be accessible through IFrameManager, Constants, and Window.default objects. On >0.8.4 (including specifically 0.9.0), we are unable to reference the objects

@hemang-thakkar
Copy link
Contributor Author

@SammySamer I have released a patch version which fixes the issue which you have been seeing. Please use this url https://cdn.jsdelivr.net/npm/@hubspot/calling-extensions-sdk@0.9.3/dist/main.js

Let me know if it fixes the issue.

@SammySamer
Copy link

@hemang-thakkar amazing, just tried it now and it's working now, really appreciate the swift fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants