-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrating src files to typescript and adding types #253
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing, thanks for converting files to TS! Could we request a calling-extensions-sdk@1 repackage to test backwards compatibility?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bravo 👏
@alonso-cadenas @esme how do i test it with sdk-test-app? |
Do we need repackage for testing? |
Yes, exactly. A repackage request must be submitted and then the ATs can be run. |
That can be done once changes are merged. right? |
It seems the change to dist/main.js (and dist/main.esm.js) bricks installing through CDN (jsDeliver). If this is intended, please update the calling-extension-sdk documentation. |
@SammySamer I am able to load sdk through this url. https://cdn.jsdelivr.net/npm/@hubspot/calling-extensions-sdk@0.9.0/dist/main.js |
@hemang-thakkar We've tried using the proposed URL, but it doesn't seem like we are able to access the sdk's functions anymore. |
@SammySamer I have released a patch version which fixes the issue which you have been seeing. Please use this url https://cdn.jsdelivr.net/npm/@hubspot/calling-extensions-sdk@0.9.3/dist/main.js Let me know if it fixes the issue. |
@hemang-thakkar amazing, just tried it now and it's working now, really appreciate the swift fix! |
Description
Jira Ticket: CALL-xxxx
Merge Checklist
BRAVE Checklist