Trigger INCOMING_CALL event in all open tabs when usesCallingWindow=false #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
esme
force-pushed
the
uses-calling-window-false
branch
from
1e1b761 to
77c1373
Compare
esme
commented
Jan 10, 2025
esme
commented
Jan 10, 2025
esme
commented
Jan 10, 2025
esme
force-pushed
the
uses-calling-window-false
branch
from
1443076 to
aa61f07
Compare
|
@esme Sorry for this but i am not getting the issue and what are we trying to solve? i thought multiple tabs is triggering INCOMING_CALL event and we wanted to avoid that. 🤔 |
|
@hemang-thakkar Zoom does not have a calling window so they trigger an INCOMING_CALL event in all of the open remote tabs. The demo minimal js is used for usesCallingWindow == false and we need to be able to do the same to verify that the solution works for them. |
alonso-cadenas
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to https://git.hubteam.com/HubSpot/calling-extensions-fe/issues/985
Trigger INCOMING_CALL event in all open tabs when usesCallingWindow=false.
Merge Checklist
BRAVE Checklist