Clear dispatch token #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 6, 2017 11:54
It seems that in certain versions of React it was possible for `componentWillMount` to be called more than once. facebook/react#6613 If that happened to a `connect`ed component, it would cause `dispatcher.unregister` to be called again with a token that was already unregistered causing an exception. This `null`s the token field so unregister can only be called once for a given token.
colbyr
force-pushed
the
clear-dispatch-token
branch
from
dcb0add
to
b1c2fc7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that in certain versions of React it was possible for
componentWillMountto be called more than once. facebook/react#6613If that happened to a
connected component, it would causedispatcher.unregisterto be called again with a token that was alreadyunregistered causing an exception.
This
nulls the token field so unregister can only be called once for agiven token.
/cc @marcneuwirth
TODOs
any new public modules are exported fromsrc/GeneralStore.jspackage.jsonandbower.jsonCHANGELOG.mdis up to date