Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better message when network error occurs #450

Closed
anthmatic opened this issue Mar 2, 2021 · 0 comments · Fixed by #481
Closed

Better message when network error occurs #450

anthmatic opened this issue Mar 2, 2021 · 0 comments · Fixed by #481
Assignees
@drewjenkins
Labels
usability

Comments

@anthmatic
Copy link
Contributor

Description and Context

If a network issue occurs while running hs fetch, an error is shown for the specific file that fails but it still shows a success message:
image

The "Success" message might cause some confusion, leading a developer to think that the fetch did successfully download all requested files

Expected behavior

We might want to show an error message and prompt the user to retry the fetch command
@drewjenkins drewjenkins self-assigned this Apr 29, 2021
@drewjenkins drewjenkins mentioned this issue Apr 29, 2021
Merged
drewjenkins added a commit that referenced this issue Apr 29, 2021
@drewjenkins
Merge pull request #481 from /issues/450
353faed 
Add error messaging for if a file fails to download
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@drewjenkins drewjenkins

Labels
usability
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add error messaging for if a file fails to download HubSpot/hubspot-cli
3 participants
@drewjenkins @brandenrodgers @anthmatic